Fix/esp lvgl port (BSP-630) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100312dog
force-pushed
the
fix/esp_lvgl_port
branch
2 times, most recently
from
7e8e82d to
450d1ec
Compare
100312dog
force-pushed
the
fix/esp_lvgl_port
branch
from
450d1ec to
9dd9bb3
Compare
100312dog
force-pushed
the
fix/esp_lvgl_port
branch
from
9dd9bb3 to
099b7e3
Compare
|
@100312dog Could you please split this PR into 2? One for s3-eye BSP and one for esp_lvgl_port? The changes in esp_lvgl_port LGTM, and I don't want to delay it anymore |
100312dog
force-pushed
the
fix/esp_lvgl_port
branch
from
099b7e3 to
3aac591
Compare
|
@tore-espressif OK, it's done. |
|
@espzav PTAL, it seems that we allocated buffers that were too big for RGB565! |
Yes, it seems that it is true. I am sorry for this mistake, I bad understanded before. I think that Gabor told it and I forgot fix it. |
espzav
approved these changes
Jan 29, 2025
tore-espressif
approved these changes
Jan 29, 2025
tore-espressif
force-pushed
the
fix/esp_lvgl_port
branch
from
3aac591 to
62c7ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description